fix(Intl): make Intl.Collator.compare a getter that returns a bound function (#62048) by ahsansheikh94 · Pull Request #62052 · microsoft/TypeScript

ahsansheikh94 · 2025-07-12T12:14:15Z

What this PR does

This PR updates the type definition for Intl.Collator.prototype.compare to align with the ECMAScript specification.

Previously, compare was declared as a method:
compare(x: string, y: string): number;

According to the spec, it is a getter that returns a bound function:
get compare(): (this: void, x: string, y: string) => number;

Changing this to a getter would cause conflicts with the existing implementations as pointed out by @Renegade334.
Instead adding a this: void gets the job done.

Changes made

Updated the Intl.Collator interface in src/lib/es5.d.ts:
Added a new conformance test in tests/cases/conformance/intl/collatorCompareBoundFunction.ts

Related Issue

Fixes #62048

…tion

ahsansheikh94 · 2025-07-12T12:16:44Z

@microsoft-github-policy-service agree

src/lib/es5.d.ts

Renegade334 · 2025-07-24T00:51:02Z

tests/cases/conformance/intl/collatorCompareBoundFunction.ts

+// @target: es2022
+// @lib: es2022.intl


es2022.intl doesn't reference lib.es5, so Collator isn't actually defined in your test script (check the baselines).

Either change this to

Suggested change

// @target: es2022

// @lib: es2022.intl

// @target: es5

// @lib: es5

or just get rid of the lib option entirely, and use the default.

DanielRosenwasser · 2026-02-07T01:10:28Z

@typescript-bot test it

typescript-bot · 2026-02-07T01:10:33Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2026-02-07T01:32:19Z

Hey @DanielRosenwasser, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2026-02-07T01:44:13Z

@DanielRosenwasser Here are the results of running the user tests with tsc comparing main and refs/pull/62052/merge:

There were infrastructure failures potentially unrelated to your change:

1 instance of "Git clone failed"

Otherwise...

Everything looks good!

typescript-bot · 2026-02-07T02:09:55Z

@DanielRosenwasser
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃	₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_82,521	_82,522	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_125,280	_125,280	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{277,802k (± 0.04%)}	_{277,692k (± 0.06%)}	_~	_277,468k	_277,909k	_{p=0.298 n=6}
_{Parse Time}	_{1.59s (± 1.80%)}	_{1.59s (± 2.51%)}	_~	_1.54s	_1.64s	_{p=0.936 n=6}
_{Bind Time}	_{0.91s (± 0.83%)}	_{0.93s (± 1.47%)}	_{+0.02s (+ 2.02%)}	_0.90s	_0.94s	_{p=0.039 n=6}
_{Check Time}	_{17.53s (± 1.97%)}	_{17.61s (± 2.08%)}	_~	_16.93s	_18.01s	_{p=1.000 n=6}
_{Emit Time}	_{3.29s (± 5.36%)}	_{3.31s (± 5.26%)}	_~	_3.21s	_3.66s	_{p=0.470 n=6}
_{Total Time}	_{23.33s (± 1.23%)}	_{23.44s (± 2.04%)}	_~	_22.68s	_24.15s	_{p=0.810 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₃	₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_957,229	_957,230	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_416,021	_416,021	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,257,842k (± 0.01%)}	_{1,257,829k (± 0.01%)}	_~	_1,257,724k	_1,257,965k	_{p=0.810 n=6}
_{Parse Time}	_{7.98s (± 0.98%)}	_{7.99s (± 0.70%)}	_~	_7.94s	_8.08s	_{p=0.936 n=6}
_{Bind Time}	_{2.39s (± 0.22%)}	_{2.40s (± 0.44%)}	_~	_2.38s	_2.41s	_{p=0.142 n=6}
_{Check Time}	_{38.85s (± 0.25%)}	_{38.82s (± 0.38%)}	_~	_38.61s	_39.06s	_{p=0.468 n=6}
_{Emit Time}	_{17.98s (± 0.27%)}	_{17.97s (± 0.45%)}	_~	_17.85s	_18.07s	_{p=0.810 n=6}
_{Total Time}	_{67.19s (± 0.11%)}	_{67.18s (± 0.23%)}	_~	_66.99s	_67.42s	_{p=0.936 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	_11,439	_11,439	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,702,777	_2,702,778	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_930,727	_930,727	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,040,186k (± 0.00%)}	_{3,040,240k (± 0.01%)}	_~	_3,039,855k	_3,040,553k	_{p=0.575 n=6}
_{Parse Time}	_{10.37s (± 0.34%)}	_{10.34s (± 0.27%)}	_~	_10.30s	_10.37s	_{p=0.126 n=6}
_{Bind Time}	_{2.78s (± 0.37%)}	_{2.79s (± 0.75%)}	_~	_2.75s	_2.81s	_{p=0.114 n=6}
_{Check Time}	_{112.75s (± 2.13%)}	_{111.70s (± 0.94%)}	_~	_110.60s	_113.54s	_{p=0.471 n=6}
_{Emit Time}	_{0.39s (± 3.24%)}	_{0.75s (±121.54%)}	_~	_0.37s	_2.63s	_{p=0.549 n=6}
_{Total Time}	_{126.28s (± 1.94%)}	_{125.58s (± 1.01%)}	_~	_124.15s	_127.11s	_{p=0.689 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,253,400	_1,253,413	_{+13 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_260,196	_260,196	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,643,835k (±14.26%)}	_{3,033,870k (± 7.77%)}	_~	_2,551,890k	_3,131,037k	_{p=0.230 n=6}
_{Parse Time}	_{6.59s (± 2.11%)}	_{6.65s (± 1.04%)}	_~	_6.51s	_6.69s	_{p=0.575 n=6}
_{Bind Time}	_{2.27s (± 1.92%)}	_{2.24s (± 1.39%)}	_~	_2.21s	_2.29s	_{p=0.470 n=6}
_{Check Time}	_{43.03s (± 0.64%)}	_{42.99s (± 0.62%)}	_~	_42.51s	_43.22s	_{p=0.810 n=6}
_{Emit Time}	_{3.48s (± 2.40%)}	_{3.54s (± 2.27%)}	_~	_3.43s	_3.66s	_{p=0.261 n=6}
_{Total Time}	_{55.36s (± 0.58%)}	_{55.42s (± 0.57%)}	_~	_54.85s	_55.74s	_{p=0.810 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,253,400	_1,253,413	_{+13 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_260,196	_260,196	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,195,171k (± 0.03%)}	_{3,073,026k (± 9.65%)}	_{🟩-122,144k (- 3.82%)}	_2,467,159k	_3,195,420k	_{p=0.045 n=6}
_{Parse Time}	_{8.42s (± 0.62%)}	_{8.43s (± 0.80%)}	_~	_8.30s	_8.48s	_{p=0.423 n=6}
_{Bind Time}	_{2.74s (± 0.72%)}	_{2.75s (± 1.41%)}	_~	_2.72s	_2.81s	_{p=0.936 n=6}
_{Check Time}	_{53.49s (± 0.46%)}	_{53.57s (± 0.34%)}	_~	_53.40s	_53.86s	_{p=0.378 n=6}
_{Emit Time}	_{4.35s (± 2.02%)}	_{4.40s (± 2.53%)}	_~	_4.25s	_4.57s	_{p=0.471 n=6}
_{Total Time}	_{69.03s (± 0.37%)}	_{69.16s (± 0.35%)}	_~	_68.86s	_69.52s	_{p=0.298 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_265,166	_265,167	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_104,270	_104,270	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{444,318k (± 0.01%)}	_{444,310k (± 0.01%)}	_~	_444,279k	_444,345k	_{p=0.810 n=6}
_{Parse Time}	_{2.87s (± 0.41%)}	_{2.89s (± 0.72%)}	_~	_2.86s	_2.92s	_{p=0.142 n=6}
_{Bind Time}	_{1.16s (± 0.71%)}	_{1.16s (± 0.72%)}	_~	_1.14s	_1.16s	_{p=1.000 n=6}
_{Check Time}	_{16.05s (± 0.48%)}	_{16.04s (± 0.34%)}	_~	_15.96s	_16.10s	_{p=0.936 n=6}
_{Emit Time}	_{1.32s (± 0.39%)}	_{1.33s (± 1.14%)}	_~	_1.31s	_1.35s	_{p=1.000 n=6}
_{Total Time}	_{21.40s (± 0.32%)}	_{21.40s (± 0.35%)}	_~	_21.32s	_21.51s	_{p=1.000 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₂₇₁	₂₇₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_225,135	_225,136	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_93,554	_93,554	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{370,570k (± 0.02%)}	_{370,556k (± 0.02%)}	_~	_370,461k	_370,633k	_{p=0.936 n=6}
_{Parse Time}	_{2.83s (± 1.14%)}	_{2.86s (± 0.65%)}	_~	_2.83s	_2.88s	_{p=0.196 n=6}
_{Bind Time}	_{1.63s (± 1.81%)}	_{1.63s (± 0.98%)}	_~	_1.61s	_1.65s	_{p=0.871 n=6}
_{Check Time}	_{17.39s (± 0.30%)}	_{17.36s (± 0.52%)}	_~	_17.26s	_17.49s	_{p=0.471 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{21.84s (± 0.28%)}	_{21.85s (± 0.46%)}	_~	_21.70s	_21.97s	_{p=1.000 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₄₀	₄₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_4,231,542	_4,231,543	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_1,343,719	_1,343,719	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{4,024,860k (± 0.00%)}	_{4,024,846k (± 0.00%)}	_~	_4,024,757k	_4,025,025k	_{p=0.748 n=6}
_{Parse Time}	_{16.30s (± 0.18%)}	_{16.36s (± 0.32%)}	_~	_16.31s	_16.44s	_{p=0.053 n=6}
_{Bind Time}	_{5.51s (± 0.50%)}	_{5.47s (± 0.67%)}	_~	_5.44s	_5.54s	_{p=0.053 n=6}
_{Check Time}	_{124.19s (± 2.26%)}	_{124.42s (± 1.52%)}	_~	_122.11s	_126.63s	_{p=0.936 n=6}
_{Emit Time}	_{50.89s (±16.97%)}	_{53.42s (±14.42%)}	_~	_44.58s	_64.25s	_{p=0.689 n=6}
_{Total Time}	_{196.89s (± 5.34%)}	_{199.67s (± 4.23%)}	_~	_189.14s	_212.77s	_{p=0.575 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₄₁	₄₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_403,241	_403,242	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_178,738	_178,738	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{560,985k (± 0.02%)}	_{561,079k (± 0.05%)}	_~	_560,873k	_561,626k	_{p=0.936 n=6}
_{Parse Time}	_{5.93s (± 0.44%)}	_{5.94s (± 0.41%)}	_~	_5.91s	_5.97s	_{p=0.222 n=6}
_{Bind Time}	_{2.51s (± 1.51%)}	_{2.50s (± 0.70%)}	_~	_2.47s	_2.52s	_{p=0.567 n=6}
_{Check Time}	_{30.25s (± 0.15%)}	_{30.33s (± 0.68%)}	_~	_29.95s	_30.53s	_{p=0.127 n=6}
_{Emit Time}	_{0.01s (±109.43%)}	_{0.00s (±154.76%)}	_~	_0.00s	_0.01s	_{p=0.640 n=6}
_{Total Time}	_{38.69s (± 0.18%)}	_{38.77s (± 0.57%)}	_~	_38.36s	_38.99s	_{p=0.127 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_752,846	_752,847	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_215,171	_215,171	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{676,996k (± 0.01%)}	_{677,025k (± 0.01%)}	_~	_676,978k	_677,064k	_{p=0.173 n=6}
_{Parse Time}	_{4.89s (± 0.28%)}	_{4.88s (± 0.84%)}	_~	_4.81s	_4.92s	_{p=0.935 n=6}
_{Bind Time}	_{1.57s (± 0.33%)}	_{1.57s (± 0.67%)}	_~	_1.55s	_1.58s	_{p=0.794 n=6}
_{Check Time}	_{22.29s (± 0.35%)}	_{22.31s (± 0.51%)}	_~	_22.11s	_22.42s	_{p=0.575 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{28.75s (± 0.28%)}	_{28.76s (± 0.54%)}	_~	_28.49s	_28.92s	_{p=0.689 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2026-02-07T02:28:29Z

@DanielRosenwasser Here are the results of running the top 400 repos with tsc comparing main and refs/pull/62052/merge:

Everything looks good!

fix(lib): change Intl.Collator.compare to getter returning bound func…

ef39bfe

…tion

github-project-automation bot added this to PR Backlog Jul 12, 2025

github-project-automation bot moved this to Not started in PR Backlog Jul 12, 2025

typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Jul 12, 2025

Renegade334 reviewed Jul 12, 2025

View reviewed changes

src/lib/es5.d.ts Outdated Show resolved Hide resolved

Fix: Add this:void to avoid conflicts with existing implementations

28630e3

thw0rted mentioned this pull request Jul 16, 2025

[unbound-method] False positive on Intl.Collator.compare (reopen #4383) typescript-eslint/typescript-eslint#7098

Open

4 tasks

Renegade334 reviewed Jul 24, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(Intl): make Intl.Collator.compare a getter that returns a bound function (#62048)#62052

fix(Intl): make Intl.Collator.compare a getter that returns a bound function (#62048)#62052
ahsansheikh94 wants to merge 2 commits intomicrosoft:mainfrom
ahsansheikh94:fix-intl-collator-compare-type

ahsansheikh94 commented Jul 12, 2025 •

edited

Loading

Uh oh!

ahsansheikh94 commented Jul 12, 2025

Uh oh!

Uh oh!

Renegade334 Jul 24, 2025

Uh oh!

DanielRosenwasser commented Feb 7, 2026

Uh oh!

typescript-bot commented Feb 7, 2026 •

edited

Loading

Uh oh!

typescript-bot commented Feb 7, 2026

Uh oh!

typescript-bot commented Feb 7, 2026

Uh oh!

typescript-bot commented Feb 7, 2026

tsc

Uh oh!

typescript-bot commented Feb 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

ahsansheikh94 commented Jul 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What this PR does

Changes made

Related Issue

Uh oh!

ahsansheikh94 commented Jul 12, 2025

Uh oh!

Uh oh!

Renegade334 Jul 24, 2025

Choose a reason for hiding this comment

Uh oh!

DanielRosenwasser commented Feb 7, 2026

Uh oh!

typescript-bot commented Feb 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Feb 7, 2026

Uh oh!

typescript-bot commented Feb 7, 2026

Uh oh!

typescript-bot commented Feb 7, 2026

tsc

Uh oh!

typescript-bot commented Feb 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ahsansheikh94 commented Jul 12, 2025 •

edited

Loading

typescript-bot commented Feb 7, 2026 •

edited

Loading